Port #[no_link] to use attribute parser #150072
Merged
+190
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
JonathanBrouwer
requested changes
Dec 16, 2025
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Bryntet
force-pushed
the
parse_no_link
branch
3 times, most recently
from
7cc78cb to
d604279
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Bryntet
force-pushed
the
parse_no_link
branch
from
d604279 to
b09a9d0
Compare
JonathanBrouwer
approved these changes
Dec 16, 2025
Member
seems like that author is unable to do so without delegate so, i will do this @bors r=JonathanBrouwer rollup |
Collaborator
Contributor
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Collaborator
|
💡 This pull request was already approved, no need to approve it again.
|
Collaborator
Contributor
|
Whoops that's some good timing lol. Thanks for the help! |
Member
yeah :) |
bors
added a commit
that referenced
this pull request
Dec 17, 2025
Rollup of 4 pull requests Successful merges: - #150000 (Port `#[rustc_legacy_const_generics]` to use attribute parser ) - #150060 (autodiff: emit an error if we fail to find libEnzyme) - #150070 (Partially revert #147888 and print warning if LLVM CMake dir is missing when building Enzyme) - #150072 (Port #[no_link] to use attribute parser) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 17, 2025
Rollup merge of #150072 - Bryntet:parse_no_link, r=JonathanBrouwer Port #[no_link] to use attribute parser Adds `#[no_link]` to the attribute parser, as well as adds tests making sure to FCW warn on `field`, `arm`, and `macrodef `
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
#[no_link]to the attribute parser, as well as adds tests making sure to FCW warn onfield,arm, andmacrodef